Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating list of Request.meta special keys #1071

Merged
merged 2 commits into from Mar 13, 2015

Conversation

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Mar 11, 2015

Hey, folks!

So, here is an update for the meta special keys, this fixes #615.
Does this look good?

Thank you!

@@ -603,6 +603,8 @@ HttpProxyMiddleware

.. versionadded:: 0.8

.. reqmeta:: proxy

.. class:: HttpProxyMiddleware

This middleware sets the HTTP proxy to use for requests, by setting the

This comment has been minimized.

@kmike

kmike Mar 11, 2015
Member

It is still not documented what should be a value of this 'proxy' meta key.

This comment has been minimized.

@eliasdorneles

eliasdorneles Mar 13, 2015
Author Member

hey, @kmike - thank you, I've added a note below.

@kmike
Copy link
Member

@kmike kmike commented Mar 13, 2015

👍

kmike added a commit that referenced this pull request Mar 13, 2015
…cial-keys

updating list of Request.meta special keys
@kmike kmike merged commit baf5c59 into scrapy:master Mar 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eliasdorneles eliasdorneles deleted the eliasdorneles:updating-request-meta-special-keys branch Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants