Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary check from scrapy.utils.spider.iter_spider_output #1078

Merged
merged 1 commit into from Mar 17, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Mar 17, 2015

arg_to_iter handles Items since 2bbd927.

I'm not sure about keeping iter_spider_output vs removing/deprecating it, but kept it for now because it seems its name can be more clear in some cases.

arg_to_iter handles Items since 2bbd927
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Mar 17, 2015

just kill it 👅

pablohoffman added a commit that referenced this pull request Mar 17, 2015
remove unnecessary check from scrapy.utils.spider.iter_spider_output
@pablohoffman pablohoffman merged commit 3f15b6d into scrapy:master Mar 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants