remove unnecessary check from scrapy.utils.spider.iter_spider_output #1078
Conversation
arg_to_iter handles Items since 2bbd927
just kill it |
pablohoffman
added a commit
that referenced
this pull request
Mar 17, 2015
remove unnecessary check from scrapy.utils.spider.iter_spider_output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
arg_to_iter handles Items since 2bbd927.
I'm not sure about keeping
iter_spider_output
vs removing/deprecating it, but kept it for now because it seems its name can be more clear in some cases.