[MRG+1] Add test for webclient with POST method and no body given

[persiyanov]

Discussed in #823

[kmike]

👍

Could you please move this check to a separate method and mark it as expectedFailure? Use https://docs.python.org/2/library/unittest.html#unittest.expectedFailure if it works (I'm not sure it'll work here), something pytest-specific if it doesn't work.

[persiyanov]

@kmike I have added few lines to ScrapyHTTPClientFactory implementation and now it passes the test. Could you check this?

[kmike]

LGTM.

I think we shouldn't set Content-Length header if it is already set, but it is not related to this issue because when body is not None scrapy also overrides the header.

[persiyanov]

Thanks for feedback, should I correct something?

[kmike]

I think this PR is fine as-is.

We usually require 2 team members to review the PR before merging (unless the PR is obvious); let's wait for someone else to check & merge it :)

[persiyanov]

Ok!

[nyov]

@drack3800, I know i'm nitpicking but please don't add whitespace on empty lines? same in your referenced bugfix. Thanks.

[persiyanov]

@nyov fixed.