Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] more python3 compatibility changes for urllib #1121

Merged
merged 1 commit into from Apr 3, 2015

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Mar 30, 2015

These are all the instances I found.

@nyov nyov force-pushed the nyov:nyov/py3-urllib branch from 31765e3 to b357005 Mar 30, 2015
@nyov nyov changed the title [WIP] more python3 compatibility changes for urllib more python3 compatibility changes for urllib Mar 30, 2015
@nyov nyov force-pushed the nyov:nyov/py3-urllib branch from b357005 to dc88be7 Apr 1, 2015
@kmike kmike changed the title more python3 compatibility changes for urllib [MRG+1] more python3 compatibility changes for urllib Apr 2, 2015
@kmike
Copy link
Member

@kmike kmike commented Apr 2, 2015

+1 to merge it.

@curita
Copy link
Member

@curita curita commented Apr 3, 2015

+2 with me :)

curita added a commit that referenced this pull request Apr 3, 2015
[MRG+1] more python3 compatibility changes for urllib
@curita curita merged commit fcf9700 into scrapy:master Apr 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nyov nyov deleted the nyov:nyov/py3-urllib branch Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants