Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deployment section covering scrapyd-deploy and shub #1124

Merged
merged 1 commit into from Apr 9, 2015

Conversation

@rdowinton
Copy link
Contributor

@rdowinton rdowinton commented Mar 31, 2015

Added a deploymention section to point readers towards scrapyd-deploy and shub documentation. Should we should also update the docs to reflect that scrapy deploy is now deprecated? I can update the PR if so.

@rdowinton
Copy link
Contributor Author

@rdowinton rdowinton commented Mar 31, 2015

Resolves #1094

@nyov
Copy link
Contributor

@nyov nyov commented Mar 31, 2015

I'm in favour, +1

People are lazy though, so I would add links for Scrapinghub and the shub documentation, beyond just the repositories (and remove the old scrapyd.rst page).

I had added the deprecation notice to the commands page for lack of a better place, but it'd make sense to move it to this page then and link to it from the other place.

@curita
Copy link
Member

@curita curita commented Mar 31, 2015

+1 to @nyov suggestions.

I'd link http://doc.scrapinghub.com/scrapy-cloud.html#deploying-a-scrapy-spider and maybe mention that you are deploying to "Scrapy Cloud" specifically, though I'm not sure if this could be confusing.

Maybe we could briefly introduce (or just link) this other tool for deploying: https://github.com/TeamHG-Memex/scrapy-dockerhub, that is not related to scrapyd. Maybe @shirk3y can help us with that.

/cc @eliasdorneles

@kmike
Copy link
Member

@kmike kmike commented Mar 31, 2015

It seems the discussion is now spread over several tickets :) Me and Nicolás commented at #1094.


scrapyd-deploy <target> -p <project>

For more information please refer to the `Deploying your project`_ section.

This comment has been minimized.

@eliasdorneles

eliasdorneles Mar 31, 2015
Member

It's probably a good idea to make it clear that this link will take you to Scrapyd Server Docs (to avoid someone clicking it while browsing Scrapy Docs and getting confused, since the sites are similar).

pablohoffman added a commit that referenced this pull request Apr 9, 2015
Added deployment section covering scrapyd-deploy and shub
@pablohoffman pablohoffman merged commit d8184a7 into scrapy:master Apr 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 9, 2015

I merged this and will work on the doc a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.