Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Move spider settings population from CrawlerRunner to Crawler.__init__ #1128

Merged

Conversation

@curita
Copy link
Member

@curita curita commented Apr 2, 2015

This change was discussed in #873

This relocation has some advantages:

  • Removes functionality from CrawlerRunner: After this change and moving the logging initialization to Crawler.init as well (made in the python logging PR #1060) we can run crawlers without CrawlerRunner intervention.
  • Settings given to each Crawler will be frozen after the extensions initialization. This allows the extensions to update the settings. That's something we want to implement for the Simplified Addons Idea for this GSoC (issue #591).
@kmike
Copy link
Member

@kmike kmike commented Apr 2, 2015

LGTM.

@kmike kmike changed the title Move spider settings population from CrawlerRunner to Crawler.__init__ [MRG+1] Move spider settings population from CrawlerRunner to Crawler.__init__ Apr 2, 2015
dangra added a commit that referenced this pull request Apr 4, 2015
…to-crawler

[MRG+1] Move spider settings population from CrawlerRunner to Crawler.__init__
@dangra dangra merged commit 9706119 into scrapy:master Apr 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@curita curita added this to the Scrapy 1.0 milestone Apr 13, 2015
@curita curita deleted the curita:move-spider-settings-population-to-crawler branch Apr 14, 2015
kmike added a commit that referenced this pull request Jun 2, 2015
#1128 moved spidercls.update_settings
call to a later stage; this commit moves it back.
@kmike kmike mentioned this pull request Jun 2, 2015
kmike added a commit that referenced this pull request Jun 3, 2015
#1128 moved spidercls.update_settings
call to a later stage; this commit moves it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.