Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1130 #1131

Merged
merged 1 commit into from Apr 14, 2015
Merged

Fix #1130 #1131

merged 1 commit into from Apr 14, 2015

Conversation

@torymur
Copy link
Contributor

@torymur torymur commented Apr 2, 2015

fixed unhandled error in deferred (RobotsTxtMiddleware)

@kmike
Copy link
Member

@kmike kmike commented Apr 2, 2015

The PR looks good, but there is an unnecessary file commited.

@torymur
Copy link
Contributor Author

@torymur torymur commented Apr 2, 2015

Oh, sorry for that! Fixed.

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 8, 2015

I'm happy to merge this as it currently stands, but I want to give a chance to @torymur to add tests until tomorrow. (robots middleware has tests in tests/test_downloadermiddleware_robotstxt.py)

@kmike
Copy link
Member

@kmike kmike commented Apr 14, 2015

Pablo is happy to merge ==> merge it!

kmike added a commit that referenced this pull request Apr 14, 2015
Fix #1130
@kmike kmike merged commit f40587c into scrapy:master Apr 14, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
return self._parsers[netloc]

def _logerror(self, failure, request, spider):
if failure.type is not IgnoreRequest:
log.msg(format="Error downloading %%(request)s: %s" % failure.value,

This comment has been minimized.

@pablohoffman

pablohoffman Apr 15, 2015
Member

double percentage symbol is a typo @torymur ?

This comment has been minimized.

@curita

curita Apr 15, 2015
Member

No, first string formatting formats '%s' at the end of the string with failure.value, and reduces one of the '%' symbols in %%(request)s. Then %(request)s is formatted inside log.msg using the call arguments.

This comment has been minimized.

@dangra

dangra Apr 16, 2015
Member

any reason to not use %(failure) and pass failure=failure.value keyword argument ?

This comment has been minimized.

@curita

curita Apr 16, 2015
Member

Not that I know of, I rebased this change in the python logging PR as such: https://github.com/scrapy/scrapy/pull/1060/files#diff-0b875f758ae81b8ccd8fb0b0a80278b2R60

This comment has been minimized.

This comment has been minimized.

@torymur

torymur Apr 30, 2015
Author Contributor

Oh, notifications land into spam folder. Julia, thanks for the answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.