Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing Crawler instances directly to CrawlerRunner.crawl() #1147

Merged
merged 3 commits into from Apr 13, 2015

Conversation

@curita
Copy link
Member

@curita curita commented Apr 10, 2015

Discussed in #873.

curita added 3 commits Apr 10, 2015
This attribute is now an internal one since it's main use-case was
covered by CrawlerRunner.stop().
@curita curita changed the title Allow passing Crawler instances directly to CrawlerManager.crawl() Allow passing Crawler instances directly to CrawlerRunner.crawl() Apr 10, 2015
dangra added a commit that referenced this pull request Apr 13, 2015
Allow passing Crawler instances directly to CrawlerRunner.crawl()
@dangra dangra merged commit e85679f into scrapy:master Apr 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@curita curita added this to the Scrapy 1.0 milestone Apr 14, 2015
@curita curita deleted the curita:pass-crawlers-to-runner-crawl-calls branch Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.