Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Crawler, CrawlerRunner and CrawlerProcess to accept dicts instead of Setting objects #1156

Merged
merged 1 commit into from Apr 15, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 14, 2015

I think that when you use Crawler, CrawlerRunner or CrawlerProcess Settings class is just an unnecessary import line. What about allowing dicts?

…ad of Setting objects
@dangra
Copy link
Member

@dangra dangra commented Apr 15, 2015

👍

curita added a commit that referenced this pull request Apr 15, 2015
allow Crawler, CrawlerRunner and CrawlerProcess to accept dicts instead of Setting objects
@curita curita merged commit 526aa07 into scrapy:master Apr 15, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kmike added a commit that referenced this pull request May 30, 2015
kmike added a commit that referenced this pull request Jun 1, 2015
See #1156

(cherry picked from commit aa6a727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.