allow Crawler, CrawlerRunner and CrawlerProcess to accept dicts instead of Setting objects #1156
Conversation
…ad of Setting objects
|
|
curita
added a commit
that referenced
this pull request
Apr 15, 2015
allow Crawler, CrawlerRunner and CrawlerProcess to accept dicts instead of Setting objects
kmike
added a commit
that referenced
this pull request
May 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I think that when you use Crawler, CrawlerRunner or CrawlerProcess Settings class is just an unnecessary import line. What about allowing dicts?