Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change local docs theme #1160

Merged
merged 3 commits into from Apr 15, 2015
Merged

Change local docs theme #1160

merged 3 commits into from Apr 15, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 14, 2015

In this PR local docs theme is made the same as http://doc.scrapy.org/en/latest/. This makes it easier to work on docs - after this change what you see locally is what you get on the official web site.

kmike added 2 commits Apr 14, 2015
sphinx_rtd_theme is builtin in recent Sphinx versions.
@kmike kmike added the docs label Apr 14, 2015
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 15, 2015

+1 but shouldn't we update docs/README to point out we need to install sphinx_rtd_theme to build the doc?

@curita
Copy link
Member

@curita curita commented Apr 15, 2015

+1, I'm using it locally actually and I've always forgot to send a PR.

Not sure if necessary, there are only two packages needed after all, but we could create a requirements.txt file inside docs/ like tests/requirements.txt.

@kmike
Copy link
Member Author

@kmike kmike commented Apr 15, 2015

@pablohoffman @curita sphinx_rtd_theme is installed automaticaly when you install recent sphinx (1.3 works).

nramirezuy added a commit that referenced this pull request Apr 15, 2015
Change local docs theme
@nramirezuy nramirezuy merged commit e054b3c into master Apr 15, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kmike kmike deleted the docs-theme branch Apr 15, 2015
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Apr 15, 2015

@kmike great, didn't know that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.