Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] rename SpiderManager to SpiderLoader #1166

Merged
merged 3 commits into from Apr 21, 2015
Merged

[MRG+1] rename SpiderManager to SpiderLoader #1166

merged 3 commits into from Apr 21, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 16, 2015

As discussed in #873.

  • spidermanager.SpiderManager is renamed to spiderloader.SpiderLoader;
  • interfaces.ISpiderManager is renamed to interfaces.ISpiderLoader;
  • SPIDER_MANAGER_CLASS is renamed to SPIDER_LOADER_CLASS;
  • interface validation is added to deprecated Crawler._spider property;
  • docstrings are added to SpiderLoader and its methods;
  • def SpiderManagerWithWrongInterface(object) is changed to class SpiderLoaderWithWrongInterface(object);
  • unfortunately I had to rename self.spiderman to self.spider_loader in tests;
  • CrawlerRunner.spiders is renamed to CrawlerRunner.spider_loader;
  • 'spiders' is removed from telnet.

What do you think about renaming CrawlerRunner.spiders to CrawlerRunner.spiderloader or CrawlerRunner.spider_loader? I'd remove it altogether, but that needs another discussion :)

@kmike
Copy link
Member Author

@kmike kmike commented Apr 16, 2015

or should it be SpiderFinder?

@curita
Copy link
Member

@curita curita commented Apr 16, 2015

Thanks for fixing the mistake in #1148 while you were on it :)

+1 to all changes, I'd rename CrawlerRunner.spiders to CrawlerRunner.spiderloader but I don't mind the underscore in the middle, both conventions seems to be used in crawler.py.

Please don't open the discussion again for the name of SpiderLoader ._. let's stick with it.

@curita curita changed the title rename SpiderManager to SpiderLoader [MRG+1] rename SpiderManager to SpiderLoader Apr 17, 2015
@curita curita added this to the Scrapy 1.0 milestone Apr 20, 2015
dangra added a commit that referenced this pull request Apr 21, 2015
[MRG+1] rename SpiderManager to SpiderLoader
@dangra dangra merged commit e034947 into master Apr 21, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dangra dangra deleted the spider-loader branch Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.