Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install service_identity package in tests to prevent warnings #1168

Merged
merged 1 commit into from Apr 29, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 16, 2015

Also, Twisted version is bumped for Python 3.x tests, just in case.

service_identity is not added to Scrapy requirements because Scrapy
supports older Twisted / PyOpenSSL versions which don't use it.

Also, Twisted version is bumped for Python 3.x tests, just in case.

service_identity is not added to Scrapy requirements because Scrapy
supports older Twisted / PyOpenSSL versions which don't use it.
@nyov
Copy link
Contributor

@nyov nyov commented Apr 28, 2015

👍
Though couldn't it be added to the tests/requirements.txt file? That way py.test without tox could use it too?

@kmike
Copy link
Member Author

@kmike kmike commented Apr 28, 2015

I haven't added it to tests/requirements.txt because it is not needed when testing against older Twisted versions.

dangra added a commit that referenced this pull request Apr 29, 2015
install service_identity package in tests to prevent warnings
@dangra dangra merged commit 5eb098a into master Apr 29, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dangra dangra deleted the service-identity branch Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants