Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG +1]fixed backwards compatibility for SPIDER_MANAGER_CLASS option #1185

Merged
merged 1 commit into from Apr 21, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Apr 21, 2015

Fixed an issue with #1166 which @dangra spotted.

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Apr 21, 2015

Shouldn't we add a deprecation warning or are we going to keep the settings?

@kmike
Copy link
Member Author

@kmike kmike commented Apr 21, 2015

There is a deprecation warning - see the test case.

@nramirezuy nramirezuy changed the title fixed backwards compatibility for SPIDER_MANAGER_CLASS option [MRG +1]fixed backwards compatibility for SPIDER_MANAGER_CLASS option Apr 21, 2015
dangra added a commit that referenced this pull request Apr 21, 2015
…tibility

[MRG +1]fixed backwards compatibility for SPIDER_MANAGER_CLASS option
@dangra dangra merged commit ded3f9c into master Apr 21, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@dangra dangra deleted the fix-spiderloader-backwards-compatibility branch Apr 21, 2015
@dangra
Copy link
Member

@dangra dangra commented Apr 21, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants