Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax SpiderLoader interface check #1187

Merged
merged 1 commit into from Apr 23, 2015
Merged

Conversation

@curita
Copy link
Member

@curita curita commented Apr 23, 2015

Raising an exception when the interface of SpiderLoader doesn't comply with scrapy.interfaces.ISpiderLoader seems unnecessary restrictive since some of its methods aren't always needed, as noted in #1148 comments.

This PR changes that by issuing a warning instead of stopping the execution with an exception.

@curita curita added this to the Scrapy 1.0 milestone Apr 23, 2015
@dangra
Copy link
Member

@dangra dangra commented Apr 23, 2015

👍 and LGTM.

kmike added a commit that referenced this pull request Apr 23, 2015
Relax SpiderLoader interface check
@kmike kmike merged commit fa1039f into scrapy:master Apr 23, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@curita curita deleted the curita:relax-spiderloader-check branch Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants