Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move base classes to their packages #1218

Merged
merged 9 commits into from May 14, 2015
Merged

Conversation

@curita
Copy link
Member

@curita curita commented May 9, 2015

This PR makes the following relocations:

  • scrapy/command.py -> scrapy/commands/__init__.py
  • scrapy/linkextractor.py -> scrapy/linkextractors/__init__.py
  • scrapy/spider.py -> scrapy/spiders/__init__.py

There are other base classes already placed in their packages. Here are some notes about them:

  • ItemLoader in scrapy/loader/__init__.py. There aren't subclasses, that's why scrapy/loader/ is singular.
  • BaseItemExporter in scrapy/exporters/__init__.py. Subclasses are inside the same scrapy/exporters/__init__.py.
  • Contract in scrapy/contracts/__init__.py. Subclasses are implemented in a single file, scrapy/contracts/default.py
  • Request in scrapy/http/request/__init__.py. Subclasses are placed in modules inside scrapy/http/request/.
  • Response in scrapy/http/response/__init__.py. Subclasses are placed in modules inside scrapy/http/response/.
  • BaseDupefilter in scrapy/dupefilters.py. Subclasses are in the same scrapy/dupefilters.py.
  • StatsCollector in scrapy/statscollectors.py. Subclasses are in the same scrapy/statscollectors.py.
@curita curita added this to the Scrapy 1.0 milestone May 9, 2015
@curita
Copy link
Member Author

@curita curita commented May 14, 2015

ping @kmike and @dangra, I need this pr merged so I can move on with the base.py relocations.

``IGNORED_EXTENSIONS`` list defined in the `scrapy.linkextractor`_
module.
``IGNORED_EXTENSIONS`` list defined in the
`scrapy.linkextractors`_ module.

This comment has been minimized.

@kmike

kmike May 14, 2015
Member

scrapy.linkextractors is a package, not a module

@kmike
Copy link
Member

@kmike kmike commented May 14, 2015

LGTM.

dangra added a commit that referenced this pull request May 14, 2015
Move base classes to their packages
@dangra dangra merged commit 1195f90 into scrapy:master May 14, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
curita added a commit to curita/scrapy that referenced this pull request May 14, 2015
@curita curita deleted the curita:move-base-to-packages branch May 14, 2015
kmike added a commit that referenced this pull request May 14, 2015
Fix in docs for error introduced in #1218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants