Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logger.exception calls to logger.error for Python compatibility #1235

Merged
merged 1 commit into from May 15, 2015

Conversation

@curita
Copy link
Member

@curita curita commented May 15, 2015

logger.exception() method didn't support keyword arguments until python 2.7.7.

I'm replacing all occurrences of this function (even those that don't have keyword arguments such as extra) so we discourage its usage.

dangra added a commit that referenced this pull request May 15, 2015
Replace logger.exception calls to logger.error for Python compatibility
@dangra dangra merged commit 2d21677 into scrapy:master May 15, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@curita curita deleted the curita:remove-log-exception-calls branch May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants