Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Remove CrawlerProcess.stopping as it isn't used any more #1258

Merged
merged 1 commit into from May 26, 2015

Conversation

@chekunkov
Copy link
Contributor

@chekunkov chekunkov commented May 26, 2015

Blame suggested that it became useless somewhere in d402735

@kmike kmike changed the title Remove CrawlerProcess.stopping as it isn't used any more [MRG+1] Remove CrawlerProcess.stopping as it isn't used any more May 26, 2015
@kmike
Copy link
Member

@kmike kmike commented May 26, 2015

I recall reviewing it; my thought was that the attribute is kept for backwards compatibility. But its value becomes misleading, and we've removed it from CrawlerRunner, so +1 to removing it from CrawlerProcess as well.

dangra added a commit that referenced this pull request May 26, 2015
…o-more

[MRG+1] Remove CrawlerProcess.stopping as it isn't used any more
@dangra dangra merged commit 5ee0886 into scrapy:master May 26, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants