Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed CrawlerProcess when settings are passed as dicts #1268

Merged
merged 1 commit into from Jun 1, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented May 30, 2015

This is a follow-up to #1156.

Without this fix CrawlerProcess({}) didn't work because log_scrapy_info wants settings['BOT_NAME'].

curita added a commit that referenced this pull request Jun 1, 2015
fixed CrawlerProcess when settings are passed as dicts
@curita curita merged commit 9d1cf23 into master Jun 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@curita curita deleted the crawlerprocess-dict-settings branch Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants