Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrawlerProcess cleanup #1284

Merged
merged 2 commits into from Jun 9, 2015
Merged

CrawlerProcess cleanup #1284

merged 2 commits into from Jun 9, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jun 5, 2015

  • removed unnecessary lambda (@curita - is it unnecessary? why did you add it?)
  • fixed #1279;
  • DNS setup is extracted to _get_dns_resolver method.
kmike added 2 commits Jun 5, 2015
* remove unneeded lambda;
* extract _get_dns_resolver method and format code to pep8.
@dangra
Copy link
Member

@dangra dangra commented Jun 5, 2015

DNS setup is extracted to _get_dns_resolver method.

is it a preparation to resolver classpath as setting?

@dangra
Copy link
Member

@dangra dangra commented Jun 5, 2015

removed unnecessary lambda (@curita - is it unnecessary? why did you add it?)

probably the result of multiples unordered merges.

@kmike
Copy link
Member Author

@kmike kmike commented Jun 5, 2015

is it a preparation to resolver classpath as setting?

No, it was just a cleanup to make code fit 80 columns :) My editor has a vertical line and barks at me when code doesn't fit.

@dangra
Copy link
Member

@dangra dangra commented Jun 5, 2015

No, it was just a cleanup to make code fit 80 columns :) My editor has a vertical line and barks at me when code doesn't fit.

good 🐶 deserves to be listen.

dangra added a commit that referenced this pull request Jun 9, 2015
CrawlerProcess cleanup
@dangra dangra merged commit 90aa5c0 into master Jun 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dangra dangra deleted the crawler-cleanup branch Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.