Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it easier to use default settings #1285

Merged
merged 1 commit into from Jun 7, 2015
Merged

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jun 5, 2015

I think that requiring users to write CrawlerRunner({}) instead of CrawlerRunner() is unnecessary.

@dangra
Copy link
Member

@dangra dangra commented Jun 5, 2015

LGTM.

dangra added a commit that referenced this pull request Jun 7, 2015
make it easier to use default settings
@dangra dangra merged commit 8729396 into master Jun 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dangra dangra deleted the optional-settings-arguments branch Jun 7, 2015
@kmike kmike mentioned this pull request Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.