Fix typos in scrapy/commands/setting.py #1293
Merged
Conversation
* intepreted -> interpreted * "a list" instead of "an float" in --getlist help * "an float"-> "a float" Also, backslashes were redundant. So I removed them.
Thanks for the corrections! Looks like |
curita
added a commit
that referenced
this pull request
Jun 9, 2015
Fix typos in scrapy/commands/setting.py
Good idea, will open a new PR for your suggestions. Thanks! Also, I noticed that --set is a global option, but --get* options are only usable with the settings command. Is this intentional? |
I think yes, you should be able to override settings while running any command, but there isn't much usefulness to get them while doing something else, that's probably why --get* options are in a command of their own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
[Cherry-picked from https://github.com/scrapy/scrapy/compare/scrapy:master...berkerpeksag:python3]
Also, backslashes were redundant. So I removed them.