Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in scrapy/commands/setting.py #1293

Merged
merged 1 commit into from Jun 9, 2015
Merged

Fix typos in scrapy/commands/setting.py #1293

merged 1 commit into from Jun 9, 2015

Conversation

@berkerpeksag
Copy link
Contributor

@berkerpeksag berkerpeksag commented Jun 9, 2015

[Cherry-picked from https://github.com/scrapy/scrapy/compare/scrapy:master...berkerpeksag:python3]

  • intepreted -> interpreted
  • "a list" instead of "an float" in --getlist help
  • "an float"-> "a float"

Also, backslashes were redundant. So I removed them.

* intepreted -> interpreted
* "a list" instead of "an float" in --getlist help
* "an float"-> "a float"

Also, backslashes were redundant. So I removed them.
@curita
Copy link
Member

@curita curita commented Jun 9, 2015

Thanks for the corrections! Looks like scrapy settings needed some attention, --getdict is missing as an option and it's probably better to print the repr() of those settings, you can't tell the type of the printed value if you use --get for example. I'll be merging this pr now, those suggested changes can be implemented later.

curita added a commit that referenced this pull request Jun 9, 2015
Fix typos in scrapy/commands/setting.py
@curita curita merged commit 9ca87c5 into scrapy:master Jun 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berkerpeksag berkerpeksag deleted the berkerpeksag:fix-typos branch Jun 9, 2015
@berkerpeksag
Copy link
Contributor Author

@berkerpeksag berkerpeksag commented Jun 10, 2015

Good idea, will open a new PR for your suggestions. Thanks! Also, I noticed that --set is a global option, but --get* options are only usable with the settings command. Is this intentional?

@curita
Copy link
Member

@curita curita commented Jun 11, 2015

I think yes, you should be able to override settings while running any command, but there isn't much usefulness to get them while doing something else, that's probably why --get* options are in a command of their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants