Autothrottle enhancements #1324
Merged
Conversation
it was deprecated for years
|
LGTM! perfectly explained and fully agree on target concurrency enhancement. |
|
does it deserve a squashed commit? |
|
Squashed last two commits. I think other commits are fine as-is, they fix separate issues and don't depend on each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey, I finally understood how AutoThrottle works :) What existing AutoThrottle extension does is very similar to setting
AutoThrottle is like a 'soft' version of the config above. I documented this, cleaned up the code a bit and added AUTOTHROTTLE_TARGET_CONCURRENCY option which allows to send more than 1 concurrent request on average using AutoThrottle.