Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autothrottle enhancements #1324

Merged
merged 6 commits into from Jun 27, 2015
Merged

Autothrottle enhancements #1324

merged 6 commits into from Jun 27, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jun 26, 2015

Hey, I finally understood how AutoThrottle works :) What existing AutoThrottle extension does is very similar to setting

CONCURRENT_REQUESTS_PER_DOMAIN=1
DOWNLOAD_DELAY=0.01

AutoThrottle is like a 'soft' version of the config above. I documented this, cleaned up the code a bit and added AUTOTHROTTLE_TARGET_CONCURRENCY option which allows to send more than 1 concurrent request on average using AutoThrottle.

@dangra
Copy link
Member

@dangra dangra commented Jun 26, 2015

LGTM! perfectly explained and fully agree on target concurrency enhancement.

@dangra
Copy link
Member

@dangra dangra commented Jun 26, 2015

does it deserve a squashed commit?

@kmike kmike force-pushed the autothrottle branch from 9f02561 to d850238 Jun 26, 2015
@kmike
Copy link
Member Author

@kmike kmike commented Jun 27, 2015

Squashed last two commits. I think other commits are fine as-is, they fix separate issues and don't depend on each other.

dangra added a commit that referenced this pull request Jun 27, 2015
Autothrottle enhancements
@dangra dangra merged commit 98707e1 into master Jun 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dangra dangra deleted the autothrottle branch Jun 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants