Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Support anonymous S3DownloadHandler (boto) connections #1358

Merged
merged 1 commit into from Jan 19, 2016

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Jul 12, 2015

(includes/based on #1357 's commit)

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jul 28, 2015

does this PR needs to be based on the lazy-load ? If not this change can be merged a lot earlier than lazy-load.

@nyov
Copy link
Contributor Author

@nyov nyov commented Jul 29, 2015

Actually not so much,
I only added it on top of it since it would have hidden boto's startup error while I was trying to get the lazy-loading to work.
I'll unstack it.

@nyov nyov force-pushed the nyov:nyov/boto-anon-connection branch from 25506c1 to 6c8d5b9 Jul 29, 2015
Also consider any unknown keyword args for S3DownloadHandler as
arguments to pass on to S3Connection (e.g. proxy settings).
@nyov nyov force-pushed the nyov:nyov/boto-anon-connection branch from 6c8d5b9 to 1b4fd3a Aug 14, 2015
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 14, 2015

Current coverage is 49.22%

Merging #1358 into master will decrease coverage by -32.95% as of 0fc03ef

@@            master   #1358   diff @@
======================================
  Files          165     165        
  Stmts         8153    8156      +3
  Branches      1134    1135      +1
  Methods          0       0        
======================================
- Hit           6699    4014   -2685
+ Partial        263     133    -130
- Missed        1191    4009   +2818

Review entire Coverage Diff as of 0fc03ef

Powered by Codecov. Updated on successful CI builds.

@kmike kmike changed the title Support anonymous S3DownloadHandler (boto) connections [MRG+1] Support anonymous S3DownloadHandler (boto) connections Jan 18, 2016
@kmike
Copy link
Member

@kmike kmike commented Jan 18, 2016

Looks good! Sorry, it took me a while to get to reviewing it.

dangra added a commit that referenced this pull request Jan 19, 2016
[MRG+1] Support anonymous S3DownloadHandler (boto) connections
@dangra dangra merged commit 5ec4319 into scrapy:master Jan 19, 2016
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 0.00% (min required 80.00%)
Details
codecov/project 49.22% (min required 82.17%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple added this to the Scrapy 1.1 milestone Jan 25, 2016
@nyov nyov deleted the nyov:nyov/boto-anon-connection branch Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants