Skip to content

/ scrapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] drop deprecated "optional_features" set #1359

Merged
merged 1 commit into from Dec 4, 2015
Merged

[MRG+1] drop deprecated "optional_features" set #1359

merged 1 commit into from Dec 4, 2015

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Jul 12, 2015

remove all optional_features support after the removal of 'boto' (#1357)
@nyov nyov force-pushed the nyov:nyov/drop-optional_features branch 2 times, most recently from 17cbd3e to b54341d Jul 29, 2015
@nyov nyov force-pushed the nyov:nyov/drop-optional_features branch from b54341d to 994f81e Aug 14, 2015
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 14, 2015

Current coverage is 82.34%

Merging #1359 into master will not affect coverage as of 3f8c290

Powered by Codecov. Updated on successful CI builds.
@nyov
Copy link
Contributor Author

@nyov nyov commented Aug 14, 2015

get lost, bot >:|
@kmike kmike changed the title drop deprecated "optional_features" set [MRG+1] drop deprecated "optional_features" set Sep 14, 2015
@kmike
Copy link
Member

@kmike kmike commented Sep 14, 2015

LGTM.
@nyov
drop deprecated "optional_features" set
Loading status checks…
ecbfe4b
@nyov
Copy link
Contributor Author

@nyov nyov commented Sep 15, 2015

I'm sorry, I know I should try doing more tests for coverage. I'm afraid my free time for contributions has very much expired :(
It's been fun while it lasted.
@nyov nyov force-pushed the nyov:nyov/drop-optional_features branch from 994f81e to ecbfe4b Sep 15, 2015
eliasdorneles added a commit that referenced this pull request Dec 4, 2015
@eliasdorneles
Merge pull request #1359 from nyov/nyov/drop-optional_features
Loading status checks…
7d18773 
[MRG+1] drop deprecated "optional_features" set
@eliasdorneles eliasdorneles merged commit 7d18773 into scrapy:master Dec 4, 2015
1 of 2 checks passed
1 of 2 checks passed
codecov/patch 66.67% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Dec 4, 2015

Thanks @nyov!
This looks great actually, don't worry too much about that bot -- it's just a (noisy) metric. :)
@nyov nyov deleted the nyov:nyov/drop-optional_features branch Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nyov @codecov-io @kmike @eliasdorneles