log level can't be int or string not in level_names #138

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant

when log.start() is called in command.py, it is called with no parameters, thus level_name_or_id will always be None. This change represents not giving the illusion of supporting random integer or string log levels. My preferred change is to support using them (see #139).

hlongmore added some commits May 26, 2012

@hlongmore hlongmore when log.start() is called in command.py, it is called with no parame…
…ters, thus level_name_or_id will always be None. This change represents not giving the illusion of supporting random integer or string log levels. My preferred change is to support using them, but that is slightly more complicated, and I've got to head to bed now.
fe593f3
@hlongmore hlongmore Forgot to include this conversion of the parameter to an int if it ca…
…n be.
8dc7aad

Oops, submitted to patch-1 instead of patch-2 for second commit. I'll just close this request, as the next one is the one that actually fixes the issue.

hlongmore closed this May 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment