Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] lazy-load s3 boto #1390

Merged
merged 1 commit into from Aug 3, 2015
Merged

[MRG+1] lazy-load s3 boto #1390

merged 1 commit into from Aug 3, 2015

Conversation

@nyov
Copy link
Contributor

@nyov nyov commented Jul 29, 2015

companion to #1357
removes s3/boto dependency on optional_features

@nyov nyov mentioned this pull request Jul 29, 2015
@@ -372,7 +372,7 @@ def _test(response):
return self.download_request(request, Spider('foo')).addCallback(_test)


class DeprecatedHttpProxyTestCase(unittest.TestCase):
class DeprecatedHttpProxyTestCase(HttpProxyTestCase):

This comment has been minimized.

@kmike

kmike Jul 29, 2015
Member

is this change related?

This comment has been minimized.

@nyov

nyov Jul 29, 2015
Author Contributor

No. I thought I would fix it while I was there.

@kmike kmike changed the title lazy-load s3 boto [MRG+1] lazy-load s3 boto Jul 29, 2015

class S3DownloadHandler(object):

def __init__(self, settings, aws_access_key_id=None, aws_secret_access_key=None, \
httpdownloadhandler=HTTPDownloadHandler):
if 'boto' not in optional_features:

try:

This comment has been minimized.

@dangra

dangra Jul 31, 2015
Member

can I ask to group all this imports into a function or method? it returns _S3Connection

@nyov nyov force-pushed the nyov:nyov/lazyload-s3-boto branch from e257366 to bf35c2a Aug 1, 2015
@nyov
Copy link
Contributor Author

@nyov nyov commented Aug 1, 2015

can I ask to group all this imports into a function or method? it returns _S3Connection

I hope this looks better, if not let me know :)

@nyov nyov force-pushed the nyov:nyov/lazyload-s3-boto branch from bf35c2a to b2fd9bd Aug 1, 2015
dangra added a commit that referenced this pull request Aug 3, 2015
[MRG+1] lazy-load s3 boto
@dangra dangra merged commit b6afd1c into scrapy:master Aug 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nyov nyov deleted the nyov:nyov/lazyload-s3-boto branch Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants