Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG +1] bpython support #1444

Merged
merged 2 commits into from Aug 27, 2015
Merged

[MRG +1] bpython support #1444

merged 2 commits into from Aug 27, 2015

Conversation

@cyberplant
Copy link
Contributor

@cyberplant cyberplant commented Aug 21, 2015

Related to #1100, this shows the banner correctly on standard python, ipython and bpython.

nyov and others added 2 commits Aug 21, 2015
Adds support for configuration of shells from scrapy.cfg
and SCRAPY_PYTHON_SHELL.

config snippet:

cat <<EOF >> ~/.scrapy.cfg
[settings]
# shell can be one of ipython, bpython or python;
# to be tried as the interactive python console
# (in above order, unless set here).
shell = python
EOF

(closes #270, #1100, #1301)
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 21, 2015

Current coverage is 82.23%

Merging #1444 into master will not affect coverage as of e8ef953

@@            master   #1444   diff @@
======================================
  Files          165     165       
  Stmts         8169    8211    +42
  Branches      1132    1138     +6
  Methods          0       0       
======================================
+ Hit           6717    6752    +35
- Partial        262     263     +1
- Missed        1190    1196     +6

Review entire Coverage Diff as of e8ef953

Powered by Codecov. Updated on successful CI builds.

@nyov
Copy link
Contributor

@nyov nyov commented Aug 21, 2015

(removed some text, bad eyes deceived me)
Nevermind, my fail :x

This looks amazing, LGTM :)

@cyberplant
Copy link
Contributor Author

@cyberplant cyberplant commented Aug 21, 2015

Hehe, I was doing some tests here, but wasn't able to reproduce your problem. 👍

@nyov
Copy link
Contributor

@nyov nyov commented Aug 21, 2015

(actually the lines moved from after the banner output to above it, I just missed them)

@nramirezuy nramirezuy changed the title bpython support [MRG +1] bpython support Aug 21, 2015
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Aug 21, 2015

<:o)

kmike added a commit that referenced this issue Aug 27, 2015
@kmike kmike merged commit 9616d91 into scrapy:master Aug 27, 2015
2 of 3 checks passed
@cyberplant
Copy link
Contributor Author

@cyberplant cyberplant commented Aug 27, 2015

Yeah! 🎆 👍 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants