Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG +1] Fix RedirectMiddleware not honouring handle_httpstatus meta keys #1447

Merged

Conversation

@jdemaeyer
Copy link
Contributor

@jdemaeyer jdemaeyer commented Aug 21, 2015

Fixup for #1364

Makes RedirectMiddleware honour the handle_httpstatus_list and handle_httpstatus_all keys from the Request.meta dictionary.

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 21, 2015

Current coverage is 82.23%

Merging #1447 into master will not affect coverage as of c9c0d54

@@            master   #1447   diff @@
======================================
  Files          165     165       
  Stmts         8169    8169       
  Branches      1132    1132       
  Methods          0       0       
======================================
  Hit           6717    6717       
  Partial        262     262       
  Missed        1190    1190       

Review entire Coverage Diff as of c9c0d54

Powered by Codecov. Updated on successful CI builds.

@nramirezuy nramirezuy changed the title Fix RedirectMiddleware not honouring handle_httpstatus meta keys [MRG +1] Fix RedirectMiddleware not honouring handle_httpstatus meta keys Aug 21, 2015
dangra added a commit that referenced this pull request Aug 22, 2015
…t-meta-attributes

[MRG +1] Fix RedirectMiddleware not honouring handle_httpstatus meta keys
@dangra dangra merged commit 489c76b into scrapy:master Aug 22, 2015
3 checks passed
3 checks passed
codecov/patch Coverage not affected
Details
codecov/project 82.23% remains the same compared to 280eab2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.