Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form submit button plain #1469

Merged
merged 2 commits into from Aug 31, 2015
Merged

Conversation

@olafdietsche
Copy link
Contributor

@olafdietsche olafdietsche commented Aug 31, 2015

Allow <button type="submit"> controls to submit forms

Forms - HTML5 and Forms - HTML4 both allow button controls as form submitter.

This patch extends _get_clickable() to allow submit buttons too.
The change from el.name and el.value to el.get(...) is needed,
because lxml parses buttons as HtmlElement and not InputElement.

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 31, 2015

Current coverage is 82.24%

Merging #1469 into master will not affect coverage as of 94e1b27

@@            master   #1469   diff @@
======================================
  Files          158     158       
  Stmts         8225    8225       
  Branches      1140    1140       
  Methods          0       0       
======================================
  Hit           6765    6765       
  Partial        264     264       
  Missed        1196    1196       

Review entire Coverage Diff as of 94e1b27

Powered by Codecov. Updated on successful CI builds.

@olafdietsche olafdietsche mentioned this pull request Aug 31, 2015
dangra added a commit that referenced this pull request Aug 31, 2015
Form submit button plain
@dangra dangra merged commit b876755 into scrapy:master Aug 31, 2015
2 checks passed
2 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@olafdietsche olafdietsche deleted the olafdietsche:form-submit-button-plain branch Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.