Form submit button plain #1469
Merged
Form submit button plain #1469
Conversation
Current coverage is
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Allow
<button type="submit">
controls to submit formsForms - HTML5 and Forms - HTML4 both allow
button
controls as form submitter.This patch extends
_get_clickable()
to allow submit buttons too.The change from
el.name
andel.value
toel.get(...)
is needed,because lxml parses buttons as
HtmlElement
and notInputElement
.