Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Incomplete submit button #1472

Merged
merged 2 commits into from Sep 2, 2015

Conversation

@olafdietsche
Copy link
Contributor

@olafdietsche olafdietsche commented Sep 1, 2015

If there is no value attribute, provides the empty string as described
in http://www.w3.org/TR/html5/forms.html#attr-button-value:

The value attribute gives the element's value for the purposes
of form submission. The element's value is the value of the
element's value attribute, if there is one, or the empty string
otherwise.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 1, 2015

Current coverage is 82.24%

Merging #1472 into master will not affect coverage as of ba52af1

@@            master   #1472   diff @@
======================================
  Files          158     158       
  Stmts         8225    8225       
  Branches      1140    1140       
  Methods          0       0       
======================================
  Hit           6765    6765       
  Partial        264     264       
  Missed        1196    1196       

Review entire Coverage Diff as of ba52af1

Powered by Codecov. Updated on successful CI builds.

@kmike kmike changed the title Incomplete submit button [MRG+1] Incomplete submit button Sep 1, 2015
dangra added a commit that referenced this pull request Sep 2, 2015
[MRG+1] Incomplete submit button
@dangra dangra merged commit bc499cb into scrapy:master Sep 2, 2015
2 checks passed
2 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@olafdietsche olafdietsche deleted the olafdietsche:incomplete-submit-button branch Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.