Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] interpreting json-amazonui-streaming as TextResponse #1503

Merged
merged 1 commit into from Sep 12, 2016

Conversation

@demelziraptor
Copy link

@demelziraptor demelziraptor commented Sep 18, 2015

Amazon is using this content type to load reviews with ajax:

ipdb> response.headers['Content-Type']
'application/json-amazonui-streaming;charset=UTF-8'

Don't know if we want to add it since it's Amazon-specific.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 18, 2015

Current coverage is 82.37%

Merging #1503 into master will decrease coverage by -0.01% as of d5b5697

Powered by Codecov. Updated on successful CI builds.

@kmike
Copy link
Member

@kmike kmike commented Sep 9, 2016

Probably a better fix would be to invest time and check that what is Scrapy doing is in line with https://mimesniff.spec.whatwg.org/. But this PR improves things, so why not merge it.

@kmike kmike changed the title interpreting json-amazonui-streaming as TextResponse [MRG+1] interpreting json-amazonui-streaming as TextResponse Sep 9, 2016
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Sep 12, 2016

I agree, this is harmless, merging.

@eliasdorneles eliasdorneles merged commit 129421c into scrapy:master Sep 12, 2016
2 checks passed
2 checks passed
codecov/patch Coverage not affected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.