[MRG+1] Startproject templates override #1575
Hello Scrapy-makers :-)
This would be my first, modest, contribution to Scrapy, that I have been pleased to use on and off for a couple of years now.
This is an attempt to address the missing override of TEMPLATES_DIR at project creation described in issue #671.
I saw PR #1035, but it seems to be on a dead end, and the reasons for that seem to be:
With this in mind, this PR keeps to the simple route proposed in the issue and copies/pastes from genspider.py.
Looking forwards to your feedback.
Finding now that the content in the first level of the templates_dir is ignored, except for scrapy.cfg.
The change is pretty easily done by doing the copytree at the project root level, and then rename 'module' to project_name.
This would impact both the files that were touched by this PR (startproject.py & test_commands.py).
My question is about the workflow: should I update this PR?
Found https://github.com/codecov/support/wiki/Commit-Coverage-Status , but did not understand the slightest part of it.
Sorry for the delay. Yeah, codecov thinks you've touched many files because scrapy master changed since the PR was opened. Rebasing on master should fix it. I think there is no need to squash, but it doesn't hurt either :)
The PR looks fine to me, +1 to merge it.
My main worry is that we probably shouldn't go too far improving scrapy template generating features; if it is hard to support IMHO it is better to switch to http://cookiecutter.readthedocs.org/en/latest/.
Nevermind the delay, I understand this is low priority.
Thanks for the explanation (sorry, I should have realized that by myself instead of wasting your time...). I will rebase/squash this evening.
Regarding template generation, I won't go any further. The purpose here is just to have the current mechanism working as documented, with no harm to a future cookiecutter implementation.