Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added: Doc for scrapy.http.TextResponse.urljoin #1582

Merged
merged 1 commit into from
Jan 23, 2022
Merged

added: Doc for scrapy.http.TextResponse.urljoin #1582

merged 1 commit into from
Jan 23, 2022

Conversation

starrify
Copy link
Contributor

@starrify starrify commented Nov 3, 2015

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 3, 2015 •
edited
Loading

Current coverage is 83.36% (diff: 100%)

Merging #1582 into master will not change coverage

Powered by Codecov. Last update 0ef570f...114437c

@kmike
Copy link
Member

kmike commented Nov 9, 2015

@Digenis a good suggestion, +1

@redapple redapple added the docs label Jan 26, 2016
@kmike
Copy link
Member

kmike commented Sep 9, 2016

The PR looks good; I think it misses a rebase, and probably it makes sense to apply @Digenis's suggestion.

@starrify starrify force-pushed the add_doc_textresponse_urljoin branch from bf8ff78 to 114437c Compare September 9, 2016 22:39
@starrify
Copy link
Contributor Author

starrify commented Sep 9, 2016

Thank you @kmike and @Digenis :)
Please have a look at this updated PR.

@Digenis
Copy link
Member

Digenis commented Sep 10, 2016

Looks good to me.

(though I don't remember my comment on the deleted diff)

@kmike kmike merged commit 9dd77b4 into scrapy:master Jan 23, 2022
@kmike
Copy link
Member

kmike commented Jan 23, 2022

Thanks @starrify, and @Digenis for susggestion (though I don't recall what it was as well :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@starrify @codecov-io @kmike @Digenis @wRAR @redapple