Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] added more verbosity for log and for exception when download is cancelled because of a size limit #1624

Merged
merged 2 commits into from Jan 18, 2016

Conversation

@side2k
Copy link

@side2k side2k commented Dec 3, 2015

We got some troubles when we needed to process such errors in our project. It is hard to link error in log with the specific download url.

Leonid Amirov added 2 commits Dec 3, 2015
…lled because of a size limit
Leonid Amirov
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Dec 10, 2015

LGTM -- better error messages FTW!

@eliasdorneles eliasdorneles changed the title added more verbosity for log and for exception when download is cancelled because of a size limit [MRG+1] added more verbosity for log and for exception when download is cancelled because of a size limit Dec 10, 2015
kmike added a commit that referenced this pull request Jan 18, 2016
[MRG+1] added more verbosity for log and for exception when download is cancelled because of a size limit
@kmike kmike merged commit fdc3c9d into scrapy:master Jan 18, 2016
0 of 2 checks passed
0 of 2 checks passed
codecov/patch CI failed: coverage not measured fully.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@redapple redapple added this to the Scrapy 1.1 milestone Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants