New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] DOC: Add captions to toctrees which appear in sidebar #1638

Merged
merged 1 commit into from Dec 14, 2015

Conversation

Projects
None yet
4 participants
@orangain
Contributor

orangain commented Dec 12, 2015

This improve readability of TOC in the sidebar. As toctrees are all hidden, captions don't appear in other place (e.g. main content of index page), as far as I know.

Before After
before after
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 12, 2015

Current coverage is 82.93%

Merging #1638 into master will not affect coverage as of 27b8502

Powered by Codecov. Updated on successful CI builds.

codecov-io commented Dec 12, 2015

Current coverage is 82.93%

Merging #1638 into master will not affect coverage as of 27b8502

Powered by Codecov. Updated on successful CI builds.

@eliasdorneles eliasdorneles changed the title from DOC: Add captions to toctrees which appear in sidebar to [MRG+1] DOC: Add captions to toctrees which appear in sidebar Dec 14, 2015

@eliasdorneles

This comment has been minimized.

Show comment
Hide comment
@eliasdorneles

eliasdorneles Dec 14, 2015

Member

Looks great!

Member

eliasdorneles commented Dec 14, 2015

Looks great!

@kmike

This comment has been minimized.

Show comment
Hide comment
@kmike

kmike Dec 14, 2015

Member

Thanks @orangain!

Member

kmike commented Dec 14, 2015

Thanks @orangain!

kmike added a commit that referenced this pull request Dec 14, 2015

Merge pull request #1638 from orangain/toc-captions
[MRG+1] DOC: Add captions to toctrees which appear in sidebar

@kmike kmike merged commit 1bc243a into scrapy:master Dec 14, 2015

2 checks passed

codecov/patch coverage not affected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@orangain

This comment has been minimized.

Show comment
Hide comment
@orangain

orangain Dec 15, 2015

Contributor

Thank you for merging 😄

Could you please cherry-pick and merge this fix into 1.0 branch too? I believe that this fix is also useful for users using current stable version, 1.0 of Scrapy. If another pull request to 1.0 branch is preferable, I will send another one.

Contributor

orangain commented Dec 15, 2015

Thank you for merging 😄

Could you please cherry-pick and merge this fix into 1.0 branch too? I believe that this fix is also useful for users using current stable version, 1.0 of Scrapy. If another pull request to 1.0 branch is preferable, I will send another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment