New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add AjaxCrawlMiddleware to DOWNLOADER_MIDDLEWARES_BASE #1643

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
2 participants
@orangain
Contributor

orangain commented Dec 18, 2015

A setting variable DOWNLOADER_MIDDLEWARES_BASE contains AjaxCrawlMiddleware in the code, but the middleware is not listed in the document of 1.0.

Code:
https://github.com/scrapy/scrapy/blob/1.0/scrapy/settings/default_settings.py#L89

Document:
http://doc.scrapy.org/en/1.0/topics/settings.html#downloader-middlewares-base

Note that this problem has already fixed in the master branch.

@kmike

This comment has been minimized.

Show comment
Hide comment
@kmike

kmike Jan 13, 2016

Member

Thanks!

Member

kmike commented Jan 13, 2016

Thanks!

kmike added a commit that referenced this pull request Jan 13, 2016

Merge pull request #1643 from orangain/doc-downloader-middleware-base…
…-1.0

DOC: Add AjaxCrawlMiddleware to DOWNLOADER_MIDDLEWARES_BASE

@kmike kmike merged commit a4b103f into scrapy:1.0 Jan 13, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment