Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] show download warnsize once #1654

Merged
merged 1 commit into from Jan 19, 2016
Merged

[MRG+1] show download warnsize once #1654

merged 1 commit into from Jan 19, 2016

Conversation

@aron-bordin
Copy link
Contributor

@aron-bordin aron-bordin commented Dec 30, 2015

PR Overview

See #1303
The warning message was too verbose. Now it is shown only a warning message per request.
The warning message is updated to show the request and the DOWNLOAD_WARNSIZE variable.

2015-12-30 13:00:18 [scrapy] WARNING: Received more bytes than download warn size (1000) in request <GET https://codeload.github.com/aron-bordin/Android-Tutorials/zip/master>.
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 30, 2015

Current coverage is 82.92%

Merging #1654 into master will decrease coverage by -0.01% as of 2e2a424

Powered by Codecov. Updated on successful CI builds.

@kmike kmike changed the title show download warnsize once [MRG+1] show download warnsize once Jan 19, 2016
@kmike
Copy link
Member

@kmike kmike commented Jan 19, 2016

Looks good, thanks!

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jan 19, 2016

@kmike can't verify what's going on on codecov, I get a 404.

@kmike
Copy link
Member

@kmike kmike commented Jan 19, 2016

@nramirezuy yeah, mee too.
Does it matter?

nramirezuy added a commit that referenced this issue Jan 19, 2016
@nramirezuy nramirezuy merged commit 6827eab into scrapy:master Jan 19, 2016
1 of 2 checks passed
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jan 19, 2016

not on this one but we should see whats about, I created a ticket ^

@redapple redapple added this to the Scrapy 1.1 milestone Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants