Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] MailSender.send: allow passing a charset. #1662

Merged
merged 2 commits into from Feb 4, 2016

Conversation

@NicolasP
Copy link
Contributor

@NicolasP NicolasP commented Jan 6, 2016

Resolves Issue #348.

The default behavior remains the same as before, but it is now possible to send utf-8 emails.

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 6, 2016

Current coverage is 83.32%

Merging #1662 into master will not affect coverage as of a716e0e

Powered by Codecov. Updated on successful CI builds.

@NicolasP NicolasP force-pushed the NicolasP:send_utf8 branch from 183575c to 6efc7a9 Feb 4, 2016
@NicolasP
Copy link
Contributor Author

@NicolasP NicolasP commented Feb 4, 2016

Hi, any chance for a review of this PR?

@kmike kmike changed the title MailSender.send: allow passing a charset. [MRG+1] MailSender.send: allow passing a charset. Feb 4, 2016
@kmike
Copy link
Member

@kmike kmike commented Feb 4, 2016

Looks good, thanks @NicolasP!

eliasdorneles added a commit that referenced this pull request Feb 4, 2016
[MRG+1] MailSender.send: allow passing a charset.
@eliasdorneles eliasdorneles merged commit daf0f66 into scrapy:master Feb 4, 2016
2 checks passed
2 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NicolasP NicolasP deleted the NicolasP:send_utf8 branch Feb 4, 2016
@redapple
Copy link
Contributor

@redapple redapple commented Feb 9, 2016

Backport to 1.1 needed

kmike added a commit that referenced this pull request Feb 15, 2016
[MRG+1] [1.1.x][backport] #1766, #1770, #1750, #1662, #1765
@redapple redapple mentioned this pull request Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.