Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Add Code of Conduct Version 1.3.0 from http://contributor-covenant.org/ #1681

Merged
merged 2 commits into from Jan 27, 2016

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Jan 15, 2016

Closes #1645

@eliasdorneles eliasdorneles changed the title Add Code of Conduct Version 1.3.0 from http://contributor-covenant.org/ [MRG+1] Add Code of Conduct Version 1.3.0 from http://contributor-covenant.org/ Jan 15, 2016
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 15, 2016

👍

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 15, 2016

Current coverage is 83.29%

Merging #1681 into master will increase coverage by +0.37% as of 44769b9

Powered by Codecov. Updated on successful CI builds.

README.rst Outdated
(see CODE_OF_CONDUCT.md).

By participating in this project you agree to abide by its terms.
Please report unacceptable behavior to opensource@scrapinghub.com.

This comment has been minimized.

@kmike

kmike Jan 16, 2016
Member

how hard would it be to setup ..@scrapy emails?

This comment has been minimized.

@redapple redapple added this to the Scrapy 1.1 milestone Jan 25, 2016
@dangra
Copy link
Member

@dangra dangra commented Jan 26, 2016

I think we should merge now as-is and change once ...@scrapy.org emails are ready.

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 26, 2016

I agree, no need for this to be blocked.

README.rst Outdated
@@ -73,6 +73,12 @@ See http://scrapy.org/community/
Contributing
============

Please note that this project is released with a Contributor Code of Conduct
(see CODE_OF_CONDUCT.md).

This comment has been minimized.

@kmike

kmike Jan 26, 2016
Member

I think it should be a link to COC at scrapy github master.

kmike added a commit that referenced this pull request Jan 27, 2016
[MRG+1] Add Code of Conduct Version 1.3.0 from http://contributor-covenant.org/
@kmike kmike merged commit 7d24df3 into scrapy:master Jan 27, 2016
1 of 2 checks passed
1 of 2 checks passed
codecov/patch 94.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple deleted the redapple:code-of-conduct branch Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.