Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stats Collection documentation for @master #1683

Merged
merged 2 commits into from Jan 15, 2016
Merged

Update Stats Collection documentation for @master #1683

merged 2 commits into from Jan 15, 2016

Conversation

@sojitko
Copy link
Contributor

@sojitko sojitko commented Jan 15, 2016

pages_crawled value doesn't exist. Replace it with downloader/response_count in order to avoid confusion.

`pages_crawled` value doesn't exist. Replace it with `downloader/response_count` in order to avoid confusion.
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 15, 2016

Current coverage is 82.93%

Merging #1683 into master will increase coverage by +0.01% as of 2523073

Powered by Codecov. Updated on successful CI builds.

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 15, 2016

Actually, I'm sorry, I realized that this is meant as an example of using the Stat Collector to add a new custom stat -- even though "it doesn't exist", it's created automatically.

So, perhaps we could make it more clear that this is an example of a custom stat, by using a name like my-custom-stat, what do you think?

@sojitko
Copy link
Contributor Author

@sojitko sojitko commented Jan 15, 2016

Good idea. Also, I have changed returned value of our custom stat to 1 (from 8) since after running first snippet, it should return exacly that. Is it OK?

@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 15, 2016

Yup, sounds good, thanks @rgtk !

eliasdorneles added a commit that referenced this pull request Jan 15, 2016
Update Stats Collection documentation for @master
@eliasdorneles eliasdorneles merged commit 3f1f15b into scrapy:master Jan 15, 2016
2 checks passed
2 checks passed
codecov/patch coverage not affected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sojitko sojitko deleted the sojitko:patch-2 branch Jan 15, 2016
@redapple redapple modified the milestone: Scrapy 1.1 Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants