Skip to content

/ scrapy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Remove --lsprof command-line option. #1689

Merged
merged 1 commit into from Jan 20, 2016
Merged

[MRG+1] Remove --lsprof command-line option. #1689

merged 1 commit into from Jan 20, 2016

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jan 18, 2016

See #1531 for motivation.
@kmike
Remove --lsprof command-line option. Fixes GH-1531
Loading status checks…
ff235fa
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 18, 2016

Current coverage is 82.98%

Merging #1689 into master will increase coverage by +0.18% as of 68c6ec0

Powered by Codecov. Updated on successful CI builds.
@eliasdorneles eliasdorneles changed the title Remove --lsprof command-line option. [MRG+1] Remove --lsprof command-line option. Jan 19, 2016
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 20, 2016

I've already +1 -- @redapple wanna do the honors here? :)
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jan 20, 2016

@kmike I've never used this option but might get someone mad xD
@kmike
Copy link
Member Author

@kmike kmike commented Jan 20, 2016

@nramirezuy it looks trivial to work around using e.g. https://pypi.python.org/pypi/pyprof2calltree
dangra added a commit that referenced this pull request Jan 20, 2016
@dangra
Merge pull request #1689 from scrapy/remove-lsprof
Loading status checks…
56b69d2 
[MRG+1] Remove --lsprof command-line option.
@dangra dangra merged commit 56b69d2 into master Jan 20, 2016
2 checks passed
2 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra
Copy link
Member

@dangra dangra commented Jan 20, 2016

🐒
@dangra dangra deleted the remove-lsprof branch Jan 20, 2016
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jan 20, 2016

🐙
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kmike @codecov-io @eliasdorneles @nramirezuy @dangra
You can’t perform that action at this time.