New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Remove --lsprof command-line option. #1689

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
5 participants
@kmike
Member

kmike commented Jan 18, 2016

See #1531 for motivation.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 18, 2016

Current coverage is 82.98%

Merging #1689 into master will increase coverage by +0.18% as of 68c6ec0

Powered by Codecov. Updated on successful CI builds.

codecov-io commented Jan 18, 2016

Current coverage is 82.98%

Merging #1689 into master will increase coverage by +0.18% as of 68c6ec0

Powered by Codecov. Updated on successful CI builds.

@eliasdorneles eliasdorneles changed the title from Remove --lsprof command-line option. to [MRG+1] Remove --lsprof command-line option. Jan 19, 2016

@eliasdorneles

This comment has been minimized.

Show comment
Hide comment
@eliasdorneles

eliasdorneles Jan 20, 2016

Member

I've already +1 -- @redapple wanna do the honors here? :)

Member

eliasdorneles commented Jan 20, 2016

I've already +1 -- @redapple wanna do the honors here? :)

@nramirezuy

This comment has been minimized.

Show comment
Hide comment
@nramirezuy

nramirezuy Jan 20, 2016

Member

@kmike I've never used this option but might get someone mad xD

Member

nramirezuy commented Jan 20, 2016

@kmike I've never used this option but might get someone mad xD

@kmike

This comment has been minimized.

Show comment
Hide comment
@kmike

kmike Jan 20, 2016

Member

@nramirezuy it looks trivial to work around using e.g. https://pypi.python.org/pypi/pyprof2calltree

Member

kmike commented Jan 20, 2016

@nramirezuy it looks trivial to work around using e.g. https://pypi.python.org/pypi/pyprof2calltree

dangra added a commit that referenced this pull request Jan 20, 2016

Merge pull request #1689 from scrapy/remove-lsprof
[MRG+1] Remove --lsprof command-line option.

@dangra dangra merged commit 56b69d2 into master Jan 20, 2016

2 checks passed

codecov/patch 100.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dangra

This comment has been minimized.

Show comment
Hide comment
@dangra

dangra Jan 20, 2016

Member

🐒

Member

dangra commented Jan 20, 2016

🐒

@dangra dangra deleted the remove-lsprof branch Jan 20, 2016

@nramirezuy

This comment has been minimized.

Show comment
Hide comment
@nramirezuy

nramirezuy Jan 20, 2016

Member

🐙

Member

nramirezuy commented Jan 20, 2016

🐙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment