[MRG+1] deprecated unused and untested code in scrapy.utils.datatypes #1720
Conversation
|
LGTM |
Current coverage is
|
eliasdorneles
changed the title
redapple
added a commit
that referenced
this pull request
Jan 26, 2016
[MRG+1] deprecated unused and untested code in scrapy.utils.datatypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey,
It seems we have some dead code in scrapy.utils.datatypes: https://codecov.io/github/scrapy/scrapy/scrapy/utils/datatypes.py?ref=b20463183c6ae39f1e0f84fe0b5abbe4b2db44c2 - MultiValueDict and SiteNode are untested and not used by scrapy itself. I checked our internal codebase and haven't found a single usage of these classes; I also checked github briefly, and haven't found it either.
MultiValueDict looks like an unmaintained copy-paste of django code; I have no idea what is SiteNode origin.