Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] deprecated unused and untested code in scrapy.utils.datatypes #1720

Merged
merged 2 commits into from Jan 26, 2016

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jan 26, 2016

Hey,

It seems we have some dead code in scrapy.utils.datatypes: https://codecov.io/github/scrapy/scrapy/scrapy/utils/datatypes.py?ref=b20463183c6ae39f1e0f84fe0b5abbe4b2db44c2 - MultiValueDict and SiteNode are untested and not used by scrapy itself. I checked our internal codebase and haven't found a single usage of these classes; I also checked github briefly, and haven't found it either.

MultiValueDict looks like an unmaintained copy-paste of django code; I have no idea what is SiteNode origin.

@redapple
Copy link
Contributor

@redapple redapple commented Jan 26, 2016

LGTM

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 26, 2016

Current coverage is 83.25%

Merging #1720 into master will not affect coverage as of be3e7d8

Powered by Codecov. Updated on successful CI builds.

@kmike kmike added this to the v1.1 milestone Jan 26, 2016
@eliasdorneles eliasdorneles changed the title deprecated unused and untested code in scrapy.utils.datatypes [MRG+1] deprecated unused and untested code in scrapy.utils.datatypes Jan 26, 2016
redapple added a commit that referenced this pull request Jan 26, 2016
[MRG+1] deprecated unused and untested code in scrapy.utils.datatypes
@redapple redapple merged commit 52daa1b into master Jan 26, 2016
1 of 2 checks passed
1 of 2 checks passed
codecov/patch 86.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike kmike deleted the deprecations branch Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.