Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] tests+doc for subdomains in offsite middleware #1721

Merged
merged 1 commit into from Jan 26, 2016

Conversation

@Digenis
Copy link
Member

@Digenis Digenis commented Jan 26, 2016

While explaining to a colleague how to restrict crawls to a specific vhost by specifying a subdomain
I noticed that the documentation doesn't demonstrate the subdomain behaviour clearly.
I then tried to point to the tests but they also lacked such an example.
As a test case it's redundant because the regex is actually tested on the TLD
so you may want me to amend the commit first.
I'd only consider it for the future possibility that someone tries to refactor the offsite middelware
and accidentally treats the top level and second level domains as a special case.

@kmike kmike changed the title tests+doc for subdomains in offsite middleware [MRG+1] tests+doc for subdomains in offsite middleware Jan 26, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 26, 2016

Current coverage is 83.25%

Merging #1721 into master will not affect coverage as of c3696e6

Powered by Codecov. Updated on successful CI builds.

eliasdorneles added a commit that referenced this issue Jan 26, 2016
[MRG+1] tests+doc for subdomains in offsite middleware
@eliasdorneles eliasdorneles merged commit de22b6f into scrapy:master Jan 26, 2016
2 checks passed
@eliasdorneles
Copy link
Member

@eliasdorneles eliasdorneles commented Jan 26, 2016

Thanks @Digenis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants