deprecate Spider.make_requests_from_url. #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
- Coverage 83.59% 80.31% -3.28%
==========================================
Files 161 161
Lines 8812 8817 +5
Branches 1296 1298 +2
==========================================
- Hits 7366 7081 -285
- Misses 1200 1482 +282
- Partials 246 254 +8
Continue to review full report at Codecov.
|
kmike
changed the title
Closed
|
What's wrong with the implementation? Can the other doc-fixes get merged (assuming they're not already in master by now). |
kmike
force-pushed
the
deprecate-make-requests-from-url
branch
from
bbfa4c0
to
692975a
Compare
kmike
commented
Feb 15, 2017
scrapy/spiders/__init__.py
Outdated
| @@ -66,10 +66,20 @@ def _set_crawler(self, crawler): | |||
| crawler.signals.connect(self.close, signals.spider_closed) | |||
|
|
|||
| def start_requests(self): | |||
| for url in self.start_urls: | |||
| yield self.make_requests_from_url(url) | |||
| if self.make_requests_from_url is not Spider.make_requests_from_url: | |||
There was a problem hiding this comment.
^^ this line is wrong because the condition is always True: bound method is not the same as unbound.
kmike
changed the title
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1495.
Todo: