[MRG+1] response.text #1730
Merged
[MRG+1] response.text #1730
Conversation
Current coverage is
|
|
I'm buying. |
|
Neat! :) |
|
Isn't better to do it backwards ? Like |
|
@nramirezuy yeah, you're right, it is better to call As for deprecations - I don't have a strong opinion here, just tried to play safe in this PR to sneak it to 1.1 :) |
|
Just add the deprecation is fine, it wont actually flood anyone. Let's keep it clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes GH-1729.
TextResponse.body_as_unicode() is old and common, so it is not deprecated. I think it is better not to flood users with warnings without a compelling reason.