Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] more efficient ExecutionEngine.spider_is_idle #1750

Merged
merged 1 commit into from Feb 5, 2016

Conversation

@kmike
Copy link
Member

@kmike kmike commented Feb 3, 2016

After this PR Scrapy will avoid calling scheduler.has_pending_requests() unless necessary. Not sure it is important, but it may save some time if scheduler.has_pending_requests() is heavy (e.g. if it needs to read something from a database).

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 3, 2016

Current coverage is 83.31%

Merging #1750 into master will decrease coverage by -0.02% as of e500934

Powered by Codecov. Updated on successful CI builds.

@nramirezuy nramirezuy changed the title more efficient ExecutionEngine.spider_is_idle [MRG+1] more efficient ExecutionEngine.spider_is_idle Feb 3, 2016
eliasdorneles added a commit that referenced this pull request Feb 5, 2016
[MRG+1] more efficient ExecutionEngine.spider_is_idle
@eliasdorneles eliasdorneles merged commit e328a9b into master Feb 5, 2016
1 of 2 checks passed
1 of 2 checks passed
codecov/patch 78.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redapple redapple deleted the spider-is-idle branch Feb 8, 2016
@redapple
Copy link
Contributor

@redapple redapple commented Feb 9, 2016

Backport to 1.1 needed

kmike added a commit that referenced this pull request Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants