[MRG+1] Change Files/ImagesPipelines class attributes to instance attributes #1891
Note: I have no way to test AWS related stuff. So I haven't touched any code related to AWS.
@kmike as you have looked at the issue before, I think you should review the PR.
I realized the changes were not backward compatible, so I rewrote it. Now it should be 100% backward compatible.
Note: If I am not wrong, some parts of the both pipelines were not covered by tests before. The only change I made in those parts was update the class attributes to a instance attribute. As there were no tests for those parts before (if I am not wrong), there are still no tests for it.
@djunzu ouch, a good call! Some options are still not documented (see http://doc.scrapy.org/en/master/topics/settings.html#settings-documented-elsewhere - not all IMAGE/FILES options have links). But that's not directly related to this PR. If you can fix that it'd be great, but a PR looks good as-is
modified: scrapy/pipelines/files.py modified: scrapy/pipelines/images.py modified: scrapy/settings/default_settings.py
modified: scrapy/pipelines/files.py modified: tests/test_pipeline_files.py