Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fix HTTP Pool key for HTTPS proxy tunneled connections (CONNECT method) #1912

Merged
merged 1 commit into from Apr 20, 2016

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Apr 8, 2016

Should fix #1807

It adds the proxy host and port to the key used to cache HTTP connections, instead of just the remote host and port.

I have no concrete proposal for unittesting this though.
I only was able to debug-print HTTP pool keys and testing with https://httpbin.org/ip with a few open HTTPS proxies.
With current code, before this patch, connections do get mixed with current default Twisted Agent key = (parsedURI.scheme, parsedURI.host, parsedURI.port)

@redapple redapple force-pushed the redapple:https-proxy-pool-key branch from 3e48cd0 to 86e4442 Apr 11, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Apr 11, 2016

Current coverage is 83.21%

Merging #1912 into master will increase coverage by +0.01% as of ae6f7da

Powered by Codecov. Updated on successful CI builds.

@redapple redapple added this to the v1.1 milestone Apr 14, 2016
@kmike kmike changed the title Fix HTTP Pool key for HTTPS proxy tunneled connections (CONNECT method) [MRG+1] Fix HTTP Pool key for HTTPS proxy tunneled connections (CONNECT method) Apr 19, 2016
@kmike
Copy link
Member

@kmike kmike commented Apr 19, 2016

The change looks good to me, but I haven't tested it on real websites.

@kmike kmike merged commit 3735eb8 into scrapy:master Apr 20, 2016
2 checks passed
2 checks passed
codecov/patch 100.00% of diff hit (target 100.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
redapple added a commit that referenced this pull request Apr 20, 2016
[backport][1.1] Fix HTTP Pool key for HTTPS proxy tunneled connections (PR #1912)
@redapple redapple deleted the redapple:https-proxy-pool-key branch Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants