Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Place brackets on own lines with JsonItemExporter #1950

Merged
merged 1 commit into from Apr 25, 2016

Conversation

@patcon
Copy link
Contributor

@patcon patcon commented Apr 24, 2016

Placing the opening and closing brackets on their own lines makes it slightly easier to sort lines after the spider_closed signal is fired. (sorting is useful when using scrapy to generate open data sets that should have consistent item order, despite request disorder)

Placing the opening and closing brackets on their own lines makes it slightly easier to sort lines after the `spider_closed` signal is fired.
@kmike kmike changed the title Place brackets on own lines with JsonItemExporter [MRG+1] Place brackets on own lines with JsonItemExporter Apr 24, 2016
@kmike
Copy link
Member

@kmike kmike commented Apr 24, 2016

Sounds fine.

@redapple redapple merged commit cf716ea into scrapy:master Apr 25, 2016
1 check passed
redapple added a commit that referenced this issue Apr 25, 2016
[backport][1.1] Place brackets on own lines with JsonItemExporter (PR #1950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants