[MRG+1] Fixed choosing of response class. #2001
Merged
Conversation
|
Hey scrapy team. |
|
@matveinazaruk thanks for this, |
matveinazaruk
force-pushed the
matveinazaruk:issue-2000
branch
4 times, most recently
from
5be3c66
to
9101fc9
Current coverage is 90.50%
|
|
@redapple Thanks for remark. Done! Can you check please? |
|
Looks good to me. |
redapple
changed the title
redapple
added a commit
that referenced
this pull request
Jul 8, 2016
[backport][1.1] Fixed choosing of response class (PR #2001)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey scrapy team!
This fix is connected to this issue.
Little changes performed will fix detecting of response type. Seems that passing
bodyintoresponsetypes.from_args(...)was missed.It caused a little incomprehension when I expected text type, and it should be text, but I had a simple
Response, notTextResponse.Thanks,
Matvei.