Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fixed choosing of response class. #2001

Merged
merged 2 commits into from Jul 8, 2016
Merged

Conversation

@matveinazaruk
Copy link
Contributor

@matveinazaruk matveinazaruk commented May 19, 2016

Hey scrapy team!

This fix is connected to this issue.
Little changes performed will fix detecting of response type. Seems that passing body into responsetypes.from_args(...) was missed.

It caused a little incomprehension when I expected text type, and it should be text, but I had a simple Response, not TextResponse.

Thanks,
Matvei.

@matveinazaruk
Copy link
Contributor Author

@matveinazaruk matveinazaruk commented May 26, 2016

Hey scrapy team.
What should I do to promote this little fix?

@redapple
Copy link
Contributor

@redapple redapple commented Jun 6, 2016

@matveinazaruk thanks for this,
could you add a test for this change?

@matveinazaruk matveinazaruk force-pushed the matveinazaruk:issue-2000 branch 4 times, most recently from 5be3c66 to 9101fc9 Jun 13, 2016
@matveinazaruk matveinazaruk force-pushed the matveinazaruk:issue-2000 branch from 9101fc9 to b76b374 Jun 13, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 13, 2016

Current coverage is 90.50%

No coverage report found for master at b7925e4.

Powered by Codecov. Last updated by b7925e4...b76b374

@matveinazaruk
Copy link
Contributor Author

@matveinazaruk matveinazaruk commented Jun 13, 2016

@redapple Thanks for remark. Done!
Also, As I've investigated it was setting simple Response in case of all types of request and all expected types of bodies.
Now it fixed for http 1.1.

Can you check please?

@redapple
Copy link
Contributor

@redapple redapple commented Jun 14, 2016

Looks good to me.
Thanks @matveinazaruk

@redapple redapple changed the title Fixed choosing of response class. [MRG+1] Fixed choosing of response class. Jun 14, 2016
@kmike kmike merged commit 52a52e2 into scrapy:master Jul 8, 2016
2 checks passed
2 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
redapple added a commit that referenced this pull request Jul 8, 2016
[backport][1.1] Fixed choosing of response class (PR #2001)
@redapple redapple added this to the v1.1.1 milestone Jul 13, 2016
@redapple redapple modified the milestone: v1.1.1 Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.